[WIP] Move to Java 11 as the minimum version to anticipate Lucene #3098

idodeclare · 2020-03-29T17:42:46Z

Upcoming Lucene 9.0.0 has updated its System Requirements with LUCENE-8738: Move to Java 11 as minimum Java version.

This is a patch to try a revised configuration to move OpenGrok to 11 too.

tarzanek · 2020-03-30T09:21:18Z

lgtm,
once this is in ... the next release should be blogged about that OpenGrok now requires jdk > 8

fwiw - I personally still use tomcat + jdk8
and opengrok + jdk8
since ... it's stable

I am not sure how much testing went into jdk11 and tomcat

same on our side, is someone using jdk > 11 + opengrok? @ahornace @tulinkry ?

tulinkry · 2020-03-30T11:06:56Z

I'm using the docker image which runs on jdk11 in production and haven't seen any problems. On my computer I use jdk12 to run opengrok and it just worked, but I haven't been very active recently to test it properly.

vladak · 2020-03-30T12:00:40Z

The instance I maintain internally is still on JDK 8 + Tomcat 8 and it might be a bit of a hurdle to jump to JDK 11 (due to Solaris x86 Java support - https://www.oracle.com/java/technologies/javase/products-doc-jdk11certconfig.html) however I feel going to JDK 11 as it is the next LSU is the way to go (JDK 14 deprecates even Solaris/SPARC anyway - https://bugs.openjdk.java.net/browse/JDK-8231554).

vladak · 2020-03-30T12:03:52Z

* same on our side, is someone using jdk > 11 + opengrok? @ahornace @tulinkry ?

I have been using JDK 11 on Ubuntu for all my local OpenGrok work for quite a while, no problems there.

pom.xml

vladak · 2020-09-30T20:02:48Z

needs rebase otherwise this is good to go from my point of view.

idodeclare · 2020-10-02T03:19:27Z

needs rebase otherwise this is good to go from my point of view.

Maddeningly after much trial and error I never got the windows build to work on this branch.

I checked now on Windows 10 20xx and a different set of errors occurs. So 🤮

vladak · 2020-10-02T12:16:18Z

I see that the Suggester tests are failing currently. Perhaps this needs the changes in #3207 ?

idodeclare · 2020-10-02T20:34:31Z

Rebased and also included a commit for Java 14 Javadoc fixes when I was trying to resolve the build on Windows (with no success)

coveralls · 2020-10-10T02:43:06Z

Pull Request Test Coverage Report for Build 5531

0 of 0 changed or added relevant lines in 0 files are covered.
536 unchanged lines in 28 files lost coverage.
Overall coverage decreased (-0.8%) to 74.906%

Files with Coverage Reduction	New Missed Lines	%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/FileHistoryCache.java	1	74.7%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/MercurialRepository.java	1	86.51%
opengrok-indexer/src/main/java/org/opengrok/indexer/history/Repository.java	1	77.7%
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java	1	60.32%
opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java	1	51.31%
opengrok-indexer/src/main/java/org/opengrok/indexer/search/context/Context.java	1	59.41%
opengrok-indexer/src/main/java/org/opengrok/indexer/search/Results.java	1	0%
opengrok-indexer/src/main/java/org/opengrok/indexer/web/Util.java	1	66.23%
plugins/src/main/java/opengrok/auth/plugin/ldap/LdapFacade.java	1	33.56%
opengrok-indexer/src/main/java/org/opengrok/indexer/search/SearchEngine.java	2	53.97%

Totals
Change from base Build 5524:	-0.8%
Covered Lines:	41274
Relevant Lines:	55101

💛 - Coveralls

ahornace · 2020-10-19T14:11:13Z

I checked now on Windows 10 20xx and a different set of errors occurs. So 🤮

I see that Windows build passed in Travis. Is OpenGrok + JDK8 working on Windows 10 20xx properly? Travis does not seem to support this version so basically any change can cause the build failure on this OS and we would be blind to it.

@vladak Cannot we wave it off? I think this is definitely a needed step.

vladak · 2020-10-19T15:18:56Z

Looks like the Windows version used for Travis build is 'windows server 2019'. Personally I am fine with whatever Windows version Travis runs on. I see the Linux/macOS checks failed because of failed download. Unfortunately I cannot restart these sub-builds, will run the build as myself.

Lucene 9.0.0 has updated its System Requirements with LUCENE-8738: Move to Java 11 as minimum Java version. (Adrien Grand, Uwe Schindler) Also: * Update jacoco to get Java 11 support. * Fix name as "Linux + OpenJDK 11" to match jdk setting. * Expand wildcard which will be needed for Java 14.

Still keeping java12plus-11-release

Also, don't bother with </p>

idodeclare · 2020-10-19T17:35:59Z

Unexpected coverage reduction of -11.4%. Not sure if due to intermittent build failure. Rebased to try again.

vladak · 2020-10-19T18:27:52Z

I restarted the builds in my branch and this time it is macOS build that is failing with:

Copying opengrok_tools-1.4.8-py3.7.egg to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/lib/python3.7/site-packages
Adding opengrok-tools 1.4.8 to easy-install.pth file
Installing opengrok script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-config-merge script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-deploy script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-groups script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-indexer script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-java script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-mirror script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-projadm script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-reindex-project script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installing opengrok-sync script to /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/bin
Installed /Users/travis/build/vladak/OpenGrok/opengrok-tools/target/env/lib/python3.7/site-packages/opengrok_tools-1.4.8-py3.7.egg

Processing dependencies for opengrok-tools==1.4.8
Searching for filelock
Reading https://pypi.org/simple/filelock/
Download error on https://pypi.org/simple/filelock/: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1076) -- Some packages may not be found!

Couldn't find index page for 'filelock' (maybe misspelled?)

I think this is hitting #2528 due to the Xcode version bump.

vladak · 2020-10-20T16:12:43Z

The last macOS build was successful. The Linux failed because of a network problem. So, there is nothing that would be blocking this.

vladak · 2020-10-20T19:15:51Z

The last macOS build was successful. The Linux failed because of a network problem. So, there is nothing that would be blocking this.

Pulled the latest branch and macOS build still fails due to setuptools vs. certificates.

vladak · 2020-10-26T07:50:16Z

Let's see if this holds up.

vladak · 2020-10-26T07:50:48Z

will update the wikis with the new Java version.

tulinkry approved these changes Mar 30, 2020

View reviewed changes

vladak reviewed Mar 30, 2020

View reviewed changes

pom.xml Show resolved Hide resolved

idodeclare force-pushed the java11 branch 4 times, most recently from 1979354 to 97786a3 Compare April 1, 2020 00:26

vladak mentioned this pull request Sep 30, 2020

FileHistoryCache#store is one big memory hog #3243

Closed

idodeclare force-pushed the java11 branch from 97786a3 to 17b9d03 Compare October 2, 2020 20:33

idodeclare force-pushed the java11 branch from 17b9d03 to 9a5a1de Compare October 10, 2020 01:58

idodeclare marked this pull request as draft October 10, 2020 17:45

idodeclare added 3 commits October 19, 2020 12:33

Fold java9plus profiles into default, per vladak.

866858d

Still keeping java12plus-11-release

Fix Javadoc for Java 14 by avoiding e.g. <h3>

bd39d39

Also, don't bother with </p>

idodeclare force-pushed the java11 branch from 9a5a1de to bd39d39 Compare October 19, 2020 17:34

vladak mentioned this pull request Oct 20, 2020

macOS Xcode 10 vs. Python setuptools #3294

Closed

vladak marked this pull request as ready for review October 26, 2020 07:49

vladak merged commit 4a04c50 into oracle:master Oct 26, 2020

idodeclare deleted the java11 branch August 8, 2021 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Move to Java 11 as the minimum version to anticipate Lucene #3098

[WIP] Move to Java 11 as the minimum version to anticipate Lucene #3098

idodeclare commented Mar 29, 2020

tarzanek commented Mar 30, 2020

tulinkry commented Mar 30, 2020 •

edited

Loading

vladak commented Mar 30, 2020 •

edited

Loading

vladak commented Mar 30, 2020

vladak commented Sep 30, 2020

idodeclare commented Oct 2, 2020

vladak commented Oct 2, 2020

idodeclare commented Oct 2, 2020

coveralls commented Oct 10, 2020 •

edited

Loading

ahornace commented Oct 19, 2020

vladak commented Oct 19, 2020 •

edited

Loading

idodeclare commented Oct 19, 2020

vladak commented Oct 19, 2020 •

edited

Loading

vladak commented Oct 20, 2020

vladak commented Oct 20, 2020

vladak commented Oct 26, 2020

vladak commented Oct 26, 2020

[WIP] Move to Java 11 as the minimum version to anticipate Lucene #3098

[WIP] Move to Java 11 as the minimum version to anticipate Lucene #3098

Conversation

idodeclare commented Mar 29, 2020

tarzanek commented Mar 30, 2020

tulinkry commented Mar 30, 2020 • edited Loading

vladak commented Mar 30, 2020 • edited Loading

vladak commented Mar 30, 2020

vladak commented Sep 30, 2020

idodeclare commented Oct 2, 2020

vladak commented Oct 2, 2020

idodeclare commented Oct 2, 2020

coveralls commented Oct 10, 2020 • edited Loading

Pull Request Test Coverage Report for Build 5531

💛 - Coveralls

ahornace commented Oct 19, 2020

vladak commented Oct 19, 2020 • edited Loading

idodeclare commented Oct 19, 2020

vladak commented Oct 19, 2020 • edited Loading

vladak commented Oct 20, 2020

vladak commented Oct 20, 2020

vladak commented Oct 26, 2020

vladak commented Oct 26, 2020

tulinkry commented Mar 30, 2020 •

edited

Loading

vladak commented Mar 30, 2020 •

edited

Loading

coveralls commented Oct 10, 2020 •

edited

Loading

vladak commented Oct 19, 2020 •

edited

Loading

vladak commented Oct 19, 2020 •

edited

Loading